-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue282 handling syntax errors in projects config #300
Issue282 handling syntax errors in projects config #300
Conversation
Travis Python 3.5 build is failing, I think VW needs to be upgraded first. Maybe merge #296? |
failing build log: https://travis-ci.org/NatLibFi/Annif/jobs/559957266 |
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
===========================================
+ Coverage 79.8% 99.39% +19.59%
===========================================
Files 55 55
Lines 2842 2969 +127
===========================================
+ Hits 2268 2951 +683
+ Misses 574 18 -556
Continue to review full report at Codecov.
|
Looks good, but there is one further case that could be covered. If
Should this case be covered too, or left for another issue/PR? |
I'll check if this can be easily covered too and implement, otherwise I'll make a new issue about this. |
Implemented raising |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, changing [noanalyzer]
to use tfidf
should be fine. It was originally added in this commit where the intent was to verify that it's possible to have a project without an analyzer. But it might be necessary to add more project configurations e.g. "fasttext-noanalyzer", "vw_multi-noanalyzer" etc. to cover all the situations where an analyzer is needed but is missing.
Raise
ConfigurationException
instead of full traceback in following situations:when trying to use (train/suggest) a project without a backend set in
projects.cfg
:This is in line with missing vocab error:
"Error: Project 'maui-fi': vocab setting is missing"
.when trying to use
projects.cfg
that has duplicated sections or entries:This closes #282.